feat(gui): Add the jp gui command plugin - #1013
Open
JeanMertz wants to merge 1 commit into
Open
Conversation
Opening the macOS app at the workspace you are already working in meant finding the bundle and passing it a path by hand. `jp gui` does it from wherever `jp` itself is pointed. The plugin resolves nothing. `InitMessage` carries a workspace root the host has already settled, so `jp gui`, `jp -w ../other gui` and `jp gui .` all arrive here answered; the plugin sends `Ready`, launches the app at that root, and sends `Exit`. The app is found by bundle identifier rather than by path, so it works wherever it is installed. Run directly from a terminal it prints its usage and says it is a plugin, rather than sitting silent waiting for a protocol message on a stdin that will never carry one. It joins `non_jp_excludes` alongside the other command plugins, so the JP-only test scope stays JP-only. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the macOS app at the workspace you are already working in meant
finding the bundle and passing it a path by hand.
jp guidoes it fromwherever
jpitself is pointed.The plugin resolves nothing.
InitMessagecarries a workspace root thehost has already settled, so
jp gui,jp -w ../other guiandjp gui .all arrive here answered; the plugin sendsReady, launchesthe app at that root, and sends
Exit. The app is found by bundleidentifier rather than by path, so it works wherever it is installed.
Run directly from a terminal it prints its usage and says it is a
plugin, rather than sitting silent waiting for a protocol message on a
stdin that will never carry one.
It joins
non_jp_excludesalongside the other command plugins, so theJP-only test scope stays JP-only.
Signed-off-by: Jean Mertz git@jeanmertz.com