chore(tools): Align RUSTFLAGS and time cargo runs - #1018
Open
JeanMertz wants to merge 1 commit into
Open
Conversation
Every cargo tool sets `RUSTFLAGS`, which replaces the `rustflags` list in `.cargo/config.toml` wholesale rather than adding to it. Only `cargo_check` and `cargo_format` were setting it, so `cargo_test` and `cargo_expand` compiled with a different flag set than their siblings. In a workspace relying on those config flags, alternating between the two groups invalidated a shared target directory and forced a full rebuild each time. All four compiling tools now set the variable, and a new `options.rustflags` appends to the `-W warnings` base so a workspace can restate the flags it needs. A malformed value is refused rather than dropped, matching how `options.root` already behaves: compiling with flags the caller believes are in effect is worse than refusing to compile. Each invocation is also timed, with the duration appended to successes and failures alike. "Check succeeded" reads identically after a warm cache and after a three-minute rebuild, and the elapsed time is the only thing that tells them apart. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every cargo tool sets
RUSTFLAGS, which replaces therustflagslist in.cargo/config.tomlwholesale rather than adding to it. Onlycargo_checkandcargo_formatwere setting it, socargo_testandcargo_expandcompiled with a different flag set than their siblings. In a workspace relying on those config flags, alternating between the two groups invalidated a shared target directory and forced a full rebuild each time.All four compiling tools now set the variable, and a new
options.rustflagsappends to the-W warningsbase so a workspace can restate the flags it needs. A malformed value is refused rather than dropped, matching howoptions.rootalready behaves: compiling with flags the caller believes are in effect is worse than refusing to compile.Each invocation is also timed, with the duration appended to successes and failures alike. "Check succeeded" reads identically after a warm cache and after a three-minute rebuild, and the elapsed time is the only thing that tells them apart.