docs(ticket): File five work items - #1019
Open
JeanMertz wants to merge 1 commit into
Open
Conversation
Five findings from a stretch of tooling work, filed rather than fixed in place so each can be judged on its own. Two concern the cargo tools: unknown `options` keys are dropped silently, so a tool configured with an option the installed binary predates reports success about the wrong thing; and `cargo_check` hardcodes `--all-targets --all-features`, which is right for this workspace but expensive when the tool is pointed elsewhere. One is missing coverage. The fs walker supports a nested `.ignore` that re-includes a subtree its parent excluded, and PR #727 rewrote that path without a test to catch a regression. One is a deferred RFD phase: a hand-authored `external = true` access rule is dropped rather than prompting for approval, so the config-only path cannot work without an unrelated `--mount` first. The last records a problem rather than a solution. A workspace cannot inherit another's config, so anything shared has to be copied and left to drift. The direction is sketched and the open questions listed; it should become an RFD before anyone implements it. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five findings from a stretch of tooling work, filed rather than fixed in place so each can be judged on its own.
Two concern the cargo tools: unknown
optionskeys are dropped silently, so a tool configured with an option the installed binary predates reports success about the wrong thing; andcargo_checkhardcodes--all-targets --all-features, which is right for this workspace but expensive when the tool is pointed elsewhere.One is missing coverage. The fs walker supports a nested
.ignorethat re-includes a subtree its parent excluded, and PR #727 rewrote that path without a test to catch a regression.One is a deferred RFD phase: a hand-authored
external = trueaccess rule is dropped rather than prompting for approval, so the config-only path cannot work without an unrelated--mountfirst.The last records a problem rather than a solution. A workspace cannot inherit another's config, so anything shared has to be copied and left to drift. The direction is sketched and the open questions listed; it should become an RFD before anyone implements it.