Conversation
`HrStyle::Line` drew a rule as wide as the terminal, but a rule spans the text column rather than the terminal, and inside a blockquote or a list item that column is narrowed by the prefix every line carries. At width 40 a `> ` quote leaves 38 columns, so a 40-column rule overflowed and wrapped onto a second line. The width now subtracts `Writer::prefix_width()`, so the rule lines up with the prose above and below it wherever it appears. A rule at the top level is unaffected, since its prefix is empty. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HrStyle::Linedrew a rule as wide as the terminal, but a rule spans the text column rather than the terminal, and inside a blockquote or a list item that column is narrowed by the prefix every line carries. At width 40 a>quote leaves 38 columns, so a 40-column rule overflowed and wrapped onto a second line.The width now subtracts
Writer::prefix_width(), so the rule lines up with the prose above and below it wherever it appears. A rule at the top level is unaffected, since its prefix is empty.