Remove unnecessary, WASM-specific code and configurations#173
Open
tzimnoch wants to merge 1 commit into
Open
Conversation
tzimnoch
commented
Jun 7, 2026
Comment on lines
-65
to
-70
| #ifdef __WASM__ | ||
| // For WASM, we can't use ErrorMessage, so we'll just print the error code | ||
| snprintf(line, sizeof(line), "error code %d", res); | ||
| #else | ||
| ErrorMessage(res, line); | ||
| #endif |
Author
There was a problem hiding this comment.
I don't know what verification proved this was initially necessary, but I haven't found it to be true. To verify I added
ErrorMessage(RETURN_TOO_MANY_CARDS, line);
printf("DDS error: %s\n", line);
outside this if block so that it would always execute and then ran node bazel-bin/examples/wasm/AnalysePlayBin.js
DDS error: Too many cards
AnalysePlayBin, hand 1: OK
WASM appears to have no problem calling this function to copy the text for error message res to line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #168 for further details.