Redesign "Partnership Policy" page#439
Conversation
📝 WalkthroughWalkthroughThe ChangesPartnership Policy Page Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for decidim-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locales/en.yml`:
- Line 499: The explanation text at line 499 in locales/en.yml is missing the
URL placeholders that were previously present. Restore the `%{main_website_url}`
placeholder where the text references "Decidim main website" and the
`%{readme_url}` placeholder where it references "GitHub project README page".
These placeholders are still being provided by the template in
source/localizable/partnership-policy.html.erb at line 17, so adding them back
will ensure the URLs are properly rendered as clickable links in the policy
copy.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: dc874aea-04dc-4067-b99e-d360710c36fc
📒 Files selected for processing (2)
locales/en.ymlsource/localizable/partnership-policy.html.erb
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Done |
|
All good in terms of copies! |
There was a problem hiding this comment.
There's currently a navigation/consistency issue here. I don't know if it will be handled now or in other PR:
- Go to this page: https://deploy-preview-439--decidim-website.netlify.app/partnership-policy/
- Click in "Back to partners" link (/partners)
- (First consistency issue/bug) This page now is called Supporters (it is also redirected to /supporters). New links should prefer both the new link and wording
- (Second consistency issue/bug) In this page, I don't have any link back to "Partnership policy", the only one is "How can governments partner with us?" but that links to https://deploy-preview-439--decidim-website.netlify.app/how-to-support/ - also if that page is for government it should be consistent the title with the slug ("how-to-support" and "How governments can partner with us?" don't match, it should be something like "how-governments-partner-us")
You're right on the redirect to "Back to partners". I guess it was due to this change e8a75b4 back in #399 when that page was originally called "Partners", although now we will now have a Partners page #440, which is very similar to how #416 is built, the wording won't change as the sprint has defined "Supporters" and "Partners"they are two separate contexts. I would say lets pick up the review to this after #440 pages are done and #416 is merged as I require components built there to complete the CMS and index (filtering & pagination). |

Summary by CodeRabbit
New Features
UI/UX Changes
Navigation