Skip to content

Redesign "Partnership Policy" page#439

Open
greenwoodt wants to merge 6 commits into
mainfrom
community/partnership-policy
Open

Redesign "Partnership Policy" page#439
greenwoodt wants to merge 6 commits into
mainfrom
community/partnership-policy

Conversation

@greenwoodt

@greenwoodt greenwoodt commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added a “back to partners” button on the partnership policy page.
  • UI/UX Changes

    • Updated partnership policy layout and typography (including heading hierarchy) for clearer readability.
    • Streamlined the partnership explanation into a single block and removed embedded external links.
    • Updated the requirements section by merging additional copy into the existing bullet list.
  • Navigation

    • Added the partnership policy page to the legal navigation menu.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The partnership-policy page is updated across three files: locales/en.yml consolidates the three-paragraph explanation into a single string and adds a back-navigation key, data/links.yml adds the route to legal navigation, and partnership-policy.html.erb renders the back-link partial, uses the consolidated translation, adjusts heading levels and text color, and restructures the requirements list.

Changes

Partnership Policy Page Update

Layer / File(s) Summary
Translation key consolidation
locales/en.yml
Adds back_to_partners key; replaces explanation.p1/p2/p3 subkeys (including %{main_website_url} and %{readme_url} template interpolations) with a single explanation string.
Navigation setup and template layout updates
data/links.yml, source/localizable/partnership-policy.html.erb
Adds /partnership-policy route to legal navigation; updates template to include arrow-link partial for back-navigation; changes explanation rendering from p1..p3 loop to single translation lookup; updates heading levels from h2 to h3; switches text color from text-gray-500 to text-black; restructures requirements so requirements.p2 becomes a list item within the bullets alongside l1 and l2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

enhancement

Suggested reviewers

  • andreslucena

Poem

🐇 Hop, hop, back to partners we go,
A single explanation, neat in a row,
The headings grew smaller, the bullets grew wide,
An arrow link added to help you glide.
Less template, more charm — what a tidy delight! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR addresses issue #404 by restructuring the partnership-policy page content and layout, adding a back-to-partners link, updating navigation links, and modifying styling as per the design requirements. The PR summary indicates four design requirements from review comments are pending implementation. Verify all spacing (64px desktop, 40px mobile content-footer, 16px mobile subtitle-body) and container alignment requirements are met.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check ✅ Passed All changes are directly related to the Partnership-policy page redesign: locale strings, page template, styling, and navigation links are within scope of issue #404.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly matches the main change: a redesign of the Partnership Policy page.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch community/partnership-policy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploy Preview for decidim-website ready!

Name Link
🔨 Latest commit 7328342
🔍 Latest deploy log https://app.netlify.com/projects/decidim-website/deploys/6a39333a7578eb0008e66c3d
😎 Deploy Preview https://deploy-preview-439--decidim-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locales/en.yml`:
- Line 499: The explanation text at line 499 in locales/en.yml is missing the
URL placeholders that were previously present. Restore the `%{main_website_url}`
placeholder where the text references "Decidim main website" and the
`%{readme_url}` placeholder where it references "GitHub project README page".
These placeholders are still being provided by the template in
source/localizable/partnership-policy.html.erb at line 17, so adding them back
will ensure the URLs are properly rendered as clickable links in the policy
copy.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc874aea-04dc-4067-b99e-d360710c36fc

📥 Commits

Reviewing files that changed from the base of the PR and between 7c48b77 and 143c180.

📒 Files selected for processing (2)
  • locales/en.yml
  • source/localizable/partnership-policy.html.erb

Comment thread locales/en.yml Outdated
@greenwoodt greenwoodt moved this from In progress to Todo in New Web Design Jun 22, 2026
@julietapasetti

julietapasetti commented Jun 22, 2026

Copy link
Copy Markdown

First review 'Partnership-policy'

  • Change these settings on mobile
Group 12175

greenwoodt and others added 3 commits June 22, 2026 14:10
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@greenwoodt

Copy link
Copy Markdown
Member Author

First review 'Partnership-policy'

* [x]  Change these settings on mobile

Done

@greenwoodt greenwoodt self-assigned this Jun 22, 2026
@elsa-decidim

Copy link
Copy Markdown
Contributor

All good in terms of copies!

@greenwoodt greenwoodt removed their assignment Jun 24, 2026
@greenwoodt greenwoodt moved this from Todo to Code Review in New Web Design Jun 24, 2026
@greenwoodt greenwoodt requested a review from andreslucena June 24, 2026 17:24

@andreslucena andreslucena left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's currently a navigation/consistency issue here. I don't know if it will be handled now or in other PR:

  1. Go to this page: https://deploy-preview-439--decidim-website.netlify.app/partnership-policy/
  2. Click in "Back to partners" link (/partners)
  3. (First consistency issue/bug) This page now is called Supporters (it is also redirected to /supporters). New links should prefer both the new link and wording
  4. (Second consistency issue/bug) In this page, I don't have any link back to "Partnership policy", the only one is "How can governments partner with us?" but that links to https://deploy-preview-439--decidim-website.netlify.app/how-to-support/ - also if that page is for government it should be consistent the title with the slug ("how-to-support" and "How governments can partner with us?" don't match, it should be something like "how-governments-partner-us")

@andreslucena andreslucena changed the title Redesign "Partnership-policy" page Redesign "Partnership Policy" page Jun 25, 2026
@greenwoodt

greenwoodt commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

There's currently a navigation/consistency issue here. I don't know if it will be handled now or in other PR:

1. Go to this page: [deploy-preview-439--decidim-website.netlify.app/partnership-policy](https://deploy-preview-439--decidim-website.netlify.app/partnership-policy/)

2. Click in "Back to partners" link (/partners)

3. (First consistency issue/bug) This page now is called Supporters (it is also redirected to /supporters). New links should prefer both the new link and wording

4. (Second consistency issue/bug) In this page, I don't have any link back to "Partnership policy", the only one is "How can governments partner with us?" but that links to [deploy-preview-439--decidim-website.netlify.app/how-to-support](https://deploy-preview-439--decidim-website.netlify.app/how-to-support/)  - also if that page is for government it should be consistent the title with the slug ("how-to-support" and "How governments can partner with us?" don't match, it should be something like "how-governments-partner-us")

You're right on the redirect to "Back to partners". I guess it was due to this change e8a75b4 back in #399 when that page was originally called "Partners", although now we will now have a Partners page #440, which is very similar to how #416 is built, the wording won't change as the sprint has defined "Supporters" and "Partners"they are two separate contexts.

I would say lets pick up the review to this after #440 pages are done and #416 is merged as I require components built there to complete the CMS and index (filtering & pagination).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Code Review

Development

Successfully merging this pull request may close these issues.

Partnership policy (community)

5 participants