[deckhouse-cli] Preserve object-level default map#374
Merged
Conversation
- `synthesizeValue` overlays a map-typed `s.Default` on top of the walked properties via `deepMergeOverride`, mirroring the precedence used for `x-example`. - Object schemas that declared both `properties` and a `default` map no longer drop the default - author-supplied values win on conflicts, unset fields fall back to the synthesized walk. - Package doc updated: rule 4 mentions the default-map overlay, rule 5 is scoped to non-object schemas. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
ldmonster
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Object schemas with both
propertiesand adefault: {...}map silently dropped the default.synthesizeValueshort-circuited onisObject(s)and returned the walk output, so rule 5 (default) never fired for object nodes.Fix
In the object branch, overlay a map-typed
s.Defaulton top of the walked properties viadeepMergeOverride. Same precedence asx-example: walked properties form the baseline, the default wins on conflicts, nested unset fields keep their synthesized fallbacks.Before / After
Schema:
Before:
After: