Skip to content

fix(disks, images): allow provisioning traffic in isolated projects #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fl64 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(disks, images): allow provisioning traffic in isolated projects #2400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion images/virtualization-artifact/pkg/common/network_policy/network_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,26 @@ package networkpolicy
import (
"context"

corev1 "k8s.io/api/core/v1"
netv1 "k8s.io/api/networking/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/intstr"
"sigs.k8s.io/controller-runtime/pkg/client"

"github.com/deckhouse/virtualization-controller/pkg/common/annotations"
"github.com/deckhouse/virtualization-controller/pkg/common/object"
"github.com/deckhouse/virtualization-controller/pkg/controller/supplements"
)

const (
moduleNamespaceLabelName = "module"
moduleVirtualization = "virtualization"

provisioningMetricsPort = 8443
uploaderPort = 8444
)

func CreateNetworkPolicy(ctx context.Context, c client.Client, obj metav1.Object, sup supplements.DataVolumeSupplement, finalizer string) error {
npName := sup.NetworkPolicy()
networkPolicy := netv1.NetworkPolicy{
Expand All @@ -52,15 +62,55 @@ func CreateNetworkPolicy(ctx context.Context, c client.Client, obj metav1.Object
},
},
},
Ingress: []netv1.NetworkPolicyIngressRule{
{
From: []netv1.NetworkPolicyPeer{
{
NamespaceSelector: &metav1.LabelSelector{
MatchLabels: map[string]string{
moduleNamespaceLabelName: moduleVirtualization,
},
},
},
},
Ports: []netv1.NetworkPolicyPort{
tcpPort(provisioningMetricsPort),
},
},
{
From: []netv1.NetworkPolicyPeer{
{
NamespaceSelector: &metav1.LabelSelector{
MatchLabels: map[string]string{
annotations.HeritageLabel: annotations.HeritageValue,
},
},
},
},
Ports: []netv1.NetworkPolicyPort{
tcpPort(uploaderPort),
},
},
},
Comment on lines +65 to +94
Copy link
Copy Markdown
Contributor

@hardcoretime hardcoretime May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not work with traffic when a user uploads a disk via the ingress URL.

Egress: []netv1.NetworkPolicyEgressRule{{}},
PolicyTypes: []netv1.PolicyType{netv1.PolicyTypeEgress},
PolicyTypes: []netv1.PolicyType{netv1.PolicyTypeIngress, netv1.PolicyTypeEgress},
},
}

err := c.Create(ctx, &networkPolicy)
return client.IgnoreAlreadyExists(err)
}

func tcpPort(port int) netv1.NetworkPolicyPort {
protocol := corev1.ProtocolTCP
targetPort := intstr.FromInt(port)

return netv1.NetworkPolicyPort{
Protocol: &protocol,
Port: &targetPort,
}
}

func GetNetworkPolicy(ctx context.Context, client client.Client, legacyName types.NamespacedName, sup supplements.Generator) (*netv1.NetworkPolicy, error) {
np, err := object.FetchObject(ctx, sup.NetworkPolicy(), client, &netv1.NetworkPolicy{})
if err != nil {
Expand Down
Loading