Show visitors row in A/B funnel tables - #24
Merged
guitavano merged 1 commit intoJul 8, 2026
Merged
Conversation
The Funnel and By-Goal tables filtered out the "visitors" baseline, so it never showed even when selected — unlike the admin screen. Include every goal (visitors included) in the tables, matching the admin. The goal bar chart still excludes visitors, whose conversion is always 100% and would flatten the other goals. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
admin-mcp | e7444f3 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 03:13 AM |
guitavano
merged commit Jul 8, 2026
220c462
into
guitavano/ab-test-results-screen
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Funnel and By-Goal tables were filtering out the
visitorsbaseline goal, so it never appeared even when selected — unlike the admin screen, wherevisitorsis the first funnel row.Fix
sortedGoals(which feeds both tables) now includes every goal,visitorsincluded — matching the admin. The goal bar chart still excludesvisitors, since its conversion is always 100% and would flatten the other goals' bars.Before → after: the Funnel table now shows the
visitorsrow (e.g.3 / 100%vs1 / 100%), consistent with the old screen.Base
Stacked on
guitavano/ab-test-results-screen(#23), which introduces the tool. GitHub will retarget this tomainonce #23 merges.Test plan
bun run build:web🤖 Generated with Claude Code
Summary by cubic
Show the visitors baseline row in the Funnel and By-Goal tables, matching the admin view and user selection. The goal bar chart still hides visitors since it’s always 100% and would flatten other bars.
Written for commit e7444f3. Summary will update on new commits.