Include visitors in A/B goals chart - #27
Merged
Merged
Conversation
The goal bar chart excluded the visitors baseline; include it so the chart matches the funnel tables and the admin screen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
admin-mcp | 8c25333 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 03:25 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "Goals" bar chart excluded the
visitorsbaseline. Include it so the chart matches the Funnel/By-Goal tables and the admin screen.barDatanow maps every goal insortedGoals(no longer filtering outvisitors).Note
visitorsrenders at 100% for both variants, which rescales the chart's Y axis — the other (low-percentage) conversion goals will appear as short bars. This matches the admin behavior.Test plan
bun run build:web🤖 Generated with Claude Code
Summary by cubic
Included the visitors baseline in the Goals bar chart so it matches the Funnel/By Goal tables and the admin view. Visitors shows as 100% for both variants, which rescales the Y-axis and makes other low-percentage goals appear shorter, matching admin behavior.
Written for commit 8c25333. Summary will update on new commits.