fix(e2e): reuse discovery browser + fix purchase-journey single-site check (#167 #168) - #169
Merged
Conversation
…167 #168) #167 - Eliminate the double Chromium launch that OOMs machines with ~1.4 GB free RAM. runLiveSelectorValidation now returns the open browser instead of closing it; runSelectorDiscoveryPass returns Browser|null; e2e.ts reuses the discovery browser for the main flow run, falling back to launchBrowser() only when discovery was skipped. Also skip categoryLink discovery when plpUrlHint is configured. #168 - Fix spurious 'prod nao produziu captura da purchase-journey' in parity e2e single-site mode. candFlows carries ALL flow captures (homepage, plp, pdp) not only purchase-journey, so candFlows.length > 0 could be true even when no purchase-journey capture exists. The single-site guard now checks candFlows.some(f => f.flow === 'purchase-journey'). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This was referenced Jul 29, 2026
Closed
JonasJesus42
added a commit
that referenced
this pull request
Jul 29, 2026
…#170) * fix(e2e): reuse discovery browser + fix single-site check detection (#167 #168) #167 - Eliminate the double Chromium launch that OOMs machines with ~1.4 GB free RAM. runLiveSelectorValidation now returns the open browser instead of closing it; runSelectorDiscoveryPass returns Browser|null; e2e.ts reuses the discovery browser for the main flow run, falling back to launchBrowser() only when discovery was skipped. Also skip categoryLink discovery when plpUrlHint is configured. #168 - Fix spurious 'prod nao produziu captura da purchase-journey' in parity e2e single-site mode. candFlows carries ALL flow captures (homepage, plp, pdp) not only purchase-journey, so candFlows.length > 0 could be true even when no purchase-journey capture exists. The single-site guard now checks candFlows.some(f => f.flow === 'purchase-journey'). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * chore(publish): bump to 0.17.7 (#169) * fix(ts): return null instead of undefined in runSelectorDiscoveryPass --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runLiveSelectorValidationnow returns the open browser instead of closing it;runSelectorDiscoveryPassreturnsBrowser | null;e2e.tsreuses the discovery browser for the main flow, falling back tolaunchBrowser()only when discovery was skipped. Also suppresses the spuriouscategoryLinkvalidation whenplpUrlHintis already configured.candFlowscarries ALL flow captures (homepage, plp, pdp) not only purchase-journey, socandFlows.length > 0was true even when no purchase-journey capture existed. The guard now checkscandFlows.some(f => f.flow === 'purchase-journey').Test plan
bun test tests/checks/purchase-journey-flow.test.ts— 12 tests passparity e2e --url http://localhost:5173/no longer exits 137parity e2ereport shows actual step counts for purchase-journey (not 0)🤖 Generated with Claude Code
Summary by cubic
Reuses the discovery Chromium instance to avoid a second launch that can OOM low‑RAM machines, and fixes single‑site purchase‑journey detection to stop false “no capture” errors. Also bumps
@decocms/parityto 0.17.7.Performance
runLiveSelectorValidationnow returns the open browser;runSelectorDiscoveryPassreturnsBrowser | null.Bug Fixes
purchase-journeycapture viacandFlows.some(f => f.flow === 'purchase-journey').categoryLinkdiscovery and validation whenplpUrlHintis set to avoid false failures on mobile.Written for commit d8f0fa5. Summary will update on new commits.