fix(helm): add CPU limits to main API and nginx containers - #5009
Open
pedrofrxncx wants to merge 1 commit into
Open
fix(helm): add CPU limits to main API and nginx containers#5009pedrofrxncx wants to merge 1 commit into
pedrofrxncx wants to merge 1 commit into
Conversation
API containers requested 750m CPU each with no ceiling, and nginx requested 500m with no CPU limit. This allows containers to burst unbounded and starve other workloads on the node. Add CPU limits aligned with best practices: 1 CPU per container (slightly above requests for headroom) matching the pattern already used for memory. The main pod now limits to ~2.5 CPU cores total (2× API + nginx) preventing resource hogging while accommodating LLM stream bursts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The main API containers requested 750m CPU each with no ceiling, and nginx requested 500m with no CPU limit. Without limits, containers can burst unbounded and starve other workloads on the node. This adds CPU limits aligned with best practices: 1 CPU per container (slightly above requests for headroom) matching the pattern already used for memory.
Verification
helm lint deploy/helm/studio/passes (0 chart failures)Testing
helm lint deploy/helm/studio/ bun run fmt # already run, no fixes neededThe main pod now limits to ~2.5 CPU cores total (2× API containers at 1 CPU each + nginx at 1 CPU) preventing resource hogging while accommodating LLM stream bursts.
Summary by cubic
Added CPU limits to the main API and nginx containers in the Helm chart to cap CPU usage and prevent node starvation. Each container now has a 1 CPU limit, capping the pod at ~2.5 CPUs while keeping current requests.
limits.cpu: "1"for API and nginx; requests remain 750m (API) and 500m (nginx).helm lintpasses.Written for commit e2d71dc. Summary will update on new commits.