fix(sandbox-preview): add aria-label to param-picker chip and extract shared badge styling - #5018
Open
pedrofrxncx wants to merge 1 commit into
Open
fix(sandbox-preview): add aria-label to param-picker chip and extract shared badge styling#5018pedrofrxncx wants to merge 1 commit into
pedrofrxncx wants to merge 1 commit into
Conversation
… shared badge styling Adds missing aria-label to the path-param picker button for better screen reader support. Extracts the repeated parameter label styling (both button and modal header badge) into a shared constant to ensure visual consistency and reduce duplication. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing
aria-labelto the path-param picker button for better screen reader support. Extracts the repeated parameter label styling (used in both the button and modal header badge) into a shared constant to ensure visual consistency and eliminate duplication.What changed
aria-labelattribute to the interactive path-param picker button (improves a11y for screen reader users)PARAM_LABEL_CLASSconstant) to eliminate duplicationTest plan
bun run fmt✓bunx tsc --noEmitin apps/mesh ✓bun test apps/mesh/src/web/components/sandbox/preview/path-param-picker.test.ts✓ (40 pass)Verification
Behavior-preserving refactor:
Summary by cubic
Adds an aria-label to the path‑param picker chip button to improve screen reader support. Extracts shared parameter badge styling into a constant used by both the chip and the modal header to keep visuals consistent and remove duplication.
Written for commit a53ee85. Summary will update on new commits.