fix(i18n): translate assignee picker strings - #5170
Open
viktormarinho wants to merge 2 commits into
Open
Conversation
Fixed hardcoded user-facing strings in assignee-picker.tsx: - placeholder "Assign to…" → taskBoard.taskDialog.assignToPlaceholder - empty state "No members found." → taskBoard.taskDialog.noMembersFound - button label "Unassigned" → taskBoard.taskDialog.unassignedLabel - group heading "Members" → taskBoard.taskDialog.membersGroupHeading All translation keys were already present in both en and pt-br dictionaries. Set up i18n domain infrastructure (domains/i18n/) with DOMAIN.md, quality.md, triage.md, and quality-baseline per the domain reconciliation protocol. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed hardcoded user-facing strings in the assignee picker component that should have been localized.
Invariant Violated
No hardcoded user-facing strings — JSX placeholders, labels, and empty states must go through
t().Evidence (Before)
Fix Applied
Updated component to use i18n via
useT():placeholder="Assign to…"→t("taskBoard.taskDialog.assignToPlaceholder")>No members found.→t("taskBoard.taskDialog.noMembersFound")value="Unassigned"→t("taskBoard.taskDialog.unassignedLabel")heading="Members"→t("taskBoard.taskDialog.membersGroupHeading")All translation keys were already present in both en and pt-br dictionaries with proper translations.
Evidence (After)
Verification with hardcoded string heuristic checks:
Infrastructure
Set up i18n domain directory (
domains/i18n/) with:DOMAIN.md— domain invariants and enforcement rulesquality.md— pt-br translation quality guidelinestriage.md— hardcoded-string triage ledger (empty; first run)quality-baseline— baseline commit SHA for subjective quality auditsSummary by cubic
Localized the assignee picker by replacing hardcoded text with
t(), and added i18n domain guardrails. Also applied Biome formatting.Bug Fixes
useT()inassignee-picker.tsx.t("taskBoard.taskDialog.assignToPlaceholder")t("taskBoard.taskDialog.noMembersFound")t("taskBoard.taskDialog.unassignedLabel")t("taskBoard.taskDialog.membersGroupHeading")Infrastructure
domains/i18n/withDOMAIN.md,quality.md,triage.md, andquality-baselineto enforce “no hardcoded strings,” pt-br parity, and quality rules.Written for commit c233758. Summary will update on new commits.