Skip to content

fix(cli): fix deco services CLI's stale duplicate of externalUrlOrNull #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrofrxncx merged 1 commit into from
Jul 24, 2026
Merged

fix(cli): fix deco services CLI's stale duplicate of externalUrlOrNull #5220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions apps/api/src/cli/commands/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,7 @@
* Replaces scripts/dev-services-cli.ts with a proper CLI subcommand.
* Plain console output — no Ink UI needed for these one-shot commands.
*/
function externalUrlOrNull(url: string | undefined): string | null {
if (!url) return null;
try {
const parsed = new URL(url);
const host = parsed.hostname;
if (host === "localhost" || host === "127.0.0.1" || host === "::1") {
return null;
}
return url;
} catch {
return null;
}
}
import { externalUrlOrNull } from "../../settings/resolve-config";

export interface ServicesOptions {
subcommand: string;
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/settings/resolve-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ function toBoolWithDefault(
* Determine if a URL points to a non-local host (i.e., an external service).
* Returns the URL string if external, null if local or not set.
*/
function externalUrlOrNull(url: string | undefined): string | null {
export function externalUrlOrNull(url: string | undefined): string | null {
if (!url) return null;
try {
const parsed = new URL(url);
Expand Down
Loading