fix(web): add API Keys menu item to settings navigation - #5337
Open
pedrofrxncx wants to merge 1 commit into
Open
fix(web): add API Keys menu item to settings navigation#5337pedrofrxncx wants to merge 1 commit into
pedrofrxncx wants to merge 1 commit into
Conversation
Add the missing API Keys entry to the settings menu for users with the api-keys:manage capability. The menu item was documented but not exposed in the UI, so owners couldn't access API key management from the settings panel. Includes the settings page view and proper i18n translations. - Add api-keys menu item to settings navigation (gated by api-keys:manage capability) - Create API Keys settings page at /$org/settings/api-keys - Add English and Portuguese translations - List existing API keys with creation dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing API Keys entry to the settings menu for users with the
api-keys:managecapability. The API Keys feature was documented and functional via the API Key Manager agent, but had no entry in the settings sidebar, making it invisible to users who expected it there.Includes a settings page view that lists existing API keys with creation dates, plus full i18n translations (English and Portuguese).
Test Plan
api-keys:managecapability/$org/settings/api-keysuseApiKeysList()Implementation Details
api-keysmenu item touseSettingsSidebarGroups()insettings-layout.tsx, gated byrequires: "api-keys:manage"i18n/en/settings.tsandi18n/pt-br/settings.tsroutes/orgs/settings/api-keys.tsxthat rendersOrgApiKeysPageviews/settings/api-keys.tsxthat displays API keys using the existinguseApiKeysList()hookKey01icon to match other credential-related menu items (secrets)Behavior is preserved: no existing tests affected, no API changes. Type checking passes with no errors.
Summary by cubic
Adds the missing “API Keys” item to Settings for users with
api-keys:manage, plus a new page to view existing keys. Makes API key management discoverable in the UI with EN/pt-BR translations.api-keys:manage./$org/settings/api-keys.useApiKeysList()with creation dates, includes empty state, loading skeleton, and error handling.Written for commit 64f50d0. Summary will update on new commits.