Add infobox file reader and dynamic SIP access content#64
Open
a2luca wants to merge 2 commits intodect-e:mainfrom
Open
Add infobox file reader and dynamic SIP access content#64a2luca wants to merge 2 commits intodect-e:mainfrom
a2luca wants to merge 2 commits intodect-e:mainfrom
Conversation
Add infobox content to the myextensions template rendering.
| infobox_file = os.path.join(app.instance_path, "infobox.html") | ||
|
|
||
| infobox_content = None | ||
| if os.path.exists(infobox_file): |
Member
There was a problem hiding this comment.
i would suggest to have the file always present and check for contents.
It seams like a #needtoknow that you can create this file.
But mybe a infobox.html.sample would to the job too
blackdotraven
requested changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my proposal for a file reader which displays the info box for sip infos with the contents of infobox.html in the instance path if the file exists.
With this change one can put infos into the info box without modifying the source code.
If you have better ideas for making this dynamic, let's discuss them here.