Encode request data as JSON when Content-Type is set to application/json

[jonkoops]

When the the Content-Type header of a request is set to application/json shouldn't the request data be converted to a JSON string using JSON.stringify?

Currently I'm sending my requests like this:

reqwest({
    url: '/api/v1/user',
    type: 'json',
    method: 'post',
    contentType: 'application/json',
    processData: false,
    data: JSON.stringify({
        first_name: 'John',
        last_name: 'Doe'
    })
});

But it would be easier if I could do this:

reqwest({
    url: '/api/v1/user',
    type: 'json',
    method: 'post',
    contentType: 'application/json',
    data: {
        first_name: 'John',
        last_name: 'Doe'
    }
});

[ded]

you can just do this:

reqwest({
  url: '/api/v1/user',
  method: 'post',
  data: {
    first_name: 'Json',
    last_name: 'Doe'
  }
})

[ded]

but to answer your question, should it be converted? i don't know. is there an authoritative source saying that it should be converted? is that the standard practice?

[jonkoops]

@ded It's a common practice to detect the Content-Type header that is returned by the server and decode the content into an Object. jQuery does this with JSON and XML returned by the server. I see no reason why we couldn't serialize Objects into their respective content-types when they are sent to the server.

[apoco]

@ded, what you posted does not work for me. Rather, a content type of application/x-www-form-urlencoded; charset=UTF-8 is sent.

I also am unable to just pass a POJO and have it converted to JSON.

[jhollingworth]

+1 very really annoying. it would be nice to support same behaviour as jquery

[ruifortes]

Same here +1

[Huxpro]

+1

[jonkoops]

I'd recommend using the new Fetch API, it does the same as request but it has a nice Promise based API. It's not in browsers yet but there are polyfills available.

[Huxpro]

@jonkoops fully agree

[danhardman]

+1 Just started using reqwest and encountered this. Definitely would be a great addition.

[torarnek]

+1

[mrconnormurphy]

+1

[danhardman]

Opened a pull request #238