CI: drop container in test-cuda - #5543
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5543 +/- ##
==========================================
- Coverage 82.46% 82.21% -0.26%
==========================================
Files 830 892 +62
Lines 88414 101562 +13148
Branches 4232 4242 +10
==========================================
+ Hits 72913 83497 +10584
- Misses 14215 16762 +2547
- Partials 1286 1303 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe CUDA CI workflow drops the ChangesCUDA CI Provisioning Overhaul
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/test_cuda.yml (1)
46-46: 💤 Low valueRemove stale comment referencing the nvidia image.
This comment
# if: false # skip as we use nvidia imageis now outdated since the container is no longer in use. Consider removing it to avoid confusion.Suggested change
&& sudo apt-get -y install cuda-toolkit-12-9 cudnn9-cuda-12 - # if: false # skip as we use nvidia image🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/test_cuda.yml at line 46, The comment on line 46 of the test_cuda.yml workflow file that states "if: false # skip as we use nvidia image" is outdated and references an nvidia image that is no longer in use. Remove this entire comment line to avoid confusion about the current state of the workflow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/test_cuda.yml:
- Around line 37-46: The CUDA toolkit is installed at /usr/local/cuda-12.9/ but
the CUDA_PATH environment variable is never exported, causing subsequent
references to $CUDA_PATH/lib64 in LD_LIBRARY_PATH exports (at lines 72 and 82)
to expand to empty strings and create malformed paths. After the
cuda-toolkit-12-9 installation command completes in the run block, add an export
command to set CUDA_PATH=/usr/local/cuda-12.9/ so that the environment variable
is properly defined for the C++ test runtime steps that depend on it.
---
Nitpick comments:
In @.github/workflows/test_cuda.yml:
- Line 46: The comment on line 46 of the test_cuda.yml workflow file that states
"if: false # skip as we use nvidia image" is outdated and references an nvidia
image that is no longer in use. Remove this entire comment line to avoid
confusion about the current state of the workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 121b70aa-8a54-4fa1-97b9-122f8d1fba56
📒 Files selected for processing (1)
.github/workflows/test_cuda.yml

Summary by CodeRabbit