fix: delegate legacy data collection

[njzjz-bot]

Summary

• Replace calls to missing template conversion scripts with the maintained DP-GEN collector.
• Preserve the legacy helper entry point as a deprecated wrapper using shuffled, per-system output.
• Point users to dpgen collect and add delegation regression coverage.

Tests

• python -m unittest tests.tools.test_collect_data -v
• ruff check dpgen/tools/collect_data.py tests/tools/test_collect_data.py
• ruff format --check dpgen/tools/collect_data.py tests/tools/test_collect_data.py
• Confirmed no missing dpgen/template, convert2raw.py, shuffle_raw.py, or raw_to_set.sh references remain in the helper.

Fixes #1894

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[coderabbitai]

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 27d68864-f46e-4f6d-98fc-31ce81266346

📥 Commits

Reviewing files that changed from the base of the PR and between d5ce577 and d243982.

📒 Files selected for processing (4)

• dpgen/collect/collect.py
• dpgen/tools/collect_data.py
• tests/test_collect.py
• tests/tools/test_collect_data.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.09%. Comparing base (d5ce577) to head (d243982).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
dpgen/collect/collect.py	81.81%	2 Missing ⚠️
dpgen/tools/collect_data.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
+ Coverage   49.80%   50.09%   +0.28%     
==========================================
  Files          83       83              
  Lines       14986    14926      -60     
==========================================
+ Hits         7464     7477      +13     
+ Misses       7522     7449      -73     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[njzjz-bot]

Independent review C

I found no blocking correctness, regression, security, or API issue in this change. CI/check evidence was considered alongside the full patch and relevant surrounding implementation. A formal APPROVE state cannot be submitted because the active njzjz-bot account is the PR author; GitHub self-review rules permit only a COMMENT review here.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent review B

No blocking findings. I reviewed the full diff, relevant surrounding behavior, tests, and current check status. GitHub does not permit njzjz-bot to APPROVE or REQUEST_CHANGES on its own pull request, so this review is recorded as COMMENT only.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent review A

A blocking backward-compatibility finding is attached inline. GitHub does not permit njzjz-bot to approve or request changes on its own PR, so this COMMENT review records the result as changes needed; no formal review state is claimed.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent re-review B

The delegation removes the missing-script failure and preserves output naming/init-data behavior, but it still changes which iteration directories the legacy entry point collects. Further changes are required from this review before the wrapper is behaviorally compatible.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent re-review C

No changes remain from this independent pass. GitHub does not allow njzjz-bot to formally approve its own PR, so this review is submitted as COMMENT rather than APPROVE.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent re-review A

No remaining correctness issues found at ef3e0c2. I checked legacy output naming, initial-data omission, non-merged collection semantics, delegation tests, and passing CI. Because this PR is authored by njzjz-bot, GitHub does not permit this account to approve its own PR; this COMMENT means no changes remain from independent re-review A.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh