Skip to content

fix: store the iteration index consistently #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njzjz-bot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: store the iteration index consistently #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dpgen/tools/auto_gen_param.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ class Iteration:

@property
def index_iteration(self):
return self._index_iteration # pylint: disable=no-member
return self._index_iteration

@index_iteration.setter
def index_iteration(self, value):
self._index_sub_iteration = value
self._index_iteration = value

@classmethod
def register_iteration(cls):
Expand Down
17 changes: 17 additions & 0 deletions tests/tools/test_auto_gen_param.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import unittest

from dpgen.tools.auto_gen_param import Iteration


class TestIterationIndex(unittest.TestCase):
def test_index_iteration_round_trip(self):
iteration = Iteration([50])
registered_index = iteration.index_iteration

self.assertIsInstance(registered_index, int)
iteration.index_iteration = 7
self.assertEqual(iteration.index_iteration, 7)


if __name__ == "__main__":
unittest.main()