Skip to content

fix: make CH4 Lebesgue example self-contained - #1951

Open
njzjz-bot wants to merge 2 commits into
masterfrom
codex/fix-1915-ch4-lebesgue-example
Open

fix: make CH4 Lebesgue example self-contained#1951
njzjz-bot wants to merge 2 commits into
masterfrom
codex/fix-1915-ch4-lebesgue-example

Conversation

@njzjz-bot

Copy link
Copy Markdown
Collaborator

Fixes #1915.

This replaces every one-line path stub in examples/CH4-lebesgue with usable local content: the workflow JSON files, POSCAR, three INCAR variants, and directory documentation. The obsolete DP1 INCAR reference is replaced with the matching current methane INCAR.

Validation:

  • python -m unittest tests.test_ch4_lebesgue_example tests.test_check_examples -v
  • ruff check tests/test_ch4_lebesgue_example.py
  • ruff format --check tests/test_ch4_lebesgue_example.py
  • python -m json.tool for every JSON file in the example
  • byte-for-byte comparison of copied inputs with their canonical source files

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Replace one-line path stubs with usable JSON, POSCAR, INCAR, and documentation content. Add regression coverage that normalizes each JSON file and parses the bundled VASP inputs.

Fixes #1915

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e7388a4-c629-4d95-aab7-ef3320018643

📥 Commits

Reviewing files that changed from the base of the PR and between d5ce577 and 98c90fc.

📒 Files selected for processing (9)
  • examples/CH4-lebesgue/CH4.POSCAR
  • examples/CH4-lebesgue/INCAR_methane
  • examples/CH4-lebesgue/INCAR_methane.md
  • examples/CH4-lebesgue/INCAR_methane.rlx
  • examples/CH4-lebesgue/README.md
  • examples/CH4-lebesgue/init.json
  • examples/CH4-lebesgue/lebesgue_v2_machine.json
  • examples/CH4-lebesgue/param_CH4_deepmd-kit-2.0.1.json
  • tests/test_ch4_lebesgue_example.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.80%. Comparing base (d5ce577) to head (98c90fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1951   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files          83       83           
  Lines       14986    14987    +1     
=======================================
+ Hits         7464     7465    +1     
  Misses       7522     7522           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review C

I found no blocking correctness, regression, security, or API issue in this change. CI/check evidence was considered alongside the full patch and relevant surrounding implementation. A formal APPROVE state cannot be submitted because the active njzjz-bot account is the PR author; GitHub self-review rules permit only a COMMENT review here.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review B\n\nBlocking finding: the documented working directory makes the shown command fail.\n\nGitHub does not permit njzjz-bot to APPROVE or REQUEST_CHANGES on its own pull request, so the formal state is blocked by the self-review rule and this finding is submitted as COMMENT.\n\nCoding agent: Codex\nCodex version: codex-cli 0.151.0\nModel: gpt-5.6-sol\nReasoning effort: xhigh

Comment thread examples/CH4-lebesgue/README.md Outdated

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review A

No blocking findings after reviewing the full diff, relevant surrounding implementation/tests, and the current check rollup. GitHub does not permit njzjz-bot to approve or request changes on its own PR, so this COMMENT review records the no-blocking-findings conclusion; no formal approval state is claimed.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review B

Re-reviewed the current head and verified that the README now gives a working directory-relative invocation. I found no blocking documentation issue. No further changes are required from this review.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review C

No changes remain from this independent pass. GitHub does not allow njzjz-bot to formally approve its own PR, so this review is submitted as COMMENT rather than APPROVE.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review A

No remaining correctness issues found at 98c90fc. I checked all copied CH4 inputs, schema normalization, VASP parsing, README guidance, and passing CI. Because this PR is authored by njzjz-bot, GitHub does not permit this account to approve its own PR; this COMMENT means no changes remain from independent re-review A.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Replace CH4-lebesgue path stubs with usable example files

1 participant