fix: make CH4 Lebesgue example self-contained - #1951
Conversation
Replace one-line path stubs with usable JSON, POSCAR, INCAR, and documentation content. Add regression coverage that normalizes each JSON file and parses the bundled VASP inputs. Fixes #1915 Coding-Agent: Codex Codex-Version: codex-cli 0.149.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1951 +/- ##
=======================================
Coverage 49.80% 49.80%
=======================================
Files 83 83
Lines 14986 14987 +1
=======================================
+ Hits 7464 7465 +1
Misses 7522 7522 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
njzjz-bot
left a comment
There was a problem hiding this comment.
Independent review C
I found no blocking correctness, regression, security, or API issue in this change. CI/check evidence was considered alongside the full patch and relevant surrounding implementation. A formal APPROVE state cannot be submitted because the active njzjz-bot account is the PR author; GitHub self-review rules permit only a COMMENT review here.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
Independent review B\n\nBlocking finding: the documented working directory makes the shown command fail.\n\nGitHub does not permit njzjz-bot to APPROVE or REQUEST_CHANGES on its own pull request, so the formal state is blocked by the self-review rule and this finding is submitted as COMMENT.\n\nCoding agent: Codex\nCodex version: codex-cli 0.151.0\nModel: gpt-5.6-sol\nReasoning effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
Independent review A
No blocking findings after reviewing the full diff, relevant surrounding implementation/tests, and the current check rollup. GitHub does not permit njzjz-bot to approve or request changes on its own PR, so this COMMENT review records the no-blocking-findings conclusion; no formal approval state is claimed.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
Coding-Agent: Codex Codex-Version: codex-cli 0.151.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
Independent re-review B
Re-reviewed the current head and verified that the README now gives a working directory-relative invocation. I found no blocking documentation issue. No further changes are required from this review.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
Independent re-review C
No changes remain from this independent pass. GitHub does not allow njzjz-bot to formally approve its own PR, so this review is submitted as COMMENT rather than APPROVE.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
Independent re-review A
No remaining correctness issues found at 98c90fc. I checked all copied CH4 inputs, schema normalization, VASP parsing, README guidance, and passing CI. Because this PR is authored by njzjz-bot, GitHub does not permit this account to approve its own PR; this COMMENT means no changes remain from independent re-review A.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
Fixes #1915.
This replaces every one-line path stub in
examples/CH4-lebesguewith usable local content: the workflow JSON files, POSCAR, three INCAR variants, and directory documentation. The obsolete DP1 INCAR reference is replaced with the matching current methane INCAR.Validation:
python -m unittest tests.test_ch4_lebesgue_example tests.test_check_examples -vruff check tests/test_ch4_lebesgue_example.pyruff format --check tests/test_ch4_lebesgue_example.pypython -m json.toolfor every JSON file in the exampleCoding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh