fix: preserve surface POSCAR input paths

[njzjz-bot]

Fixes #1912.

Summary:

• Pass the complete from_poscar_path to pymatgen when creating surface supercells.
• Exercise the surface workflow with a POSCAR stored outside the working directory.

Validation:

• PYTHONPATH=/home/jzzeng/codes/dpgen python -m unittest tests.data.test_gen_surf_poscar -v
• ruff check dpgen/data/surf.py tests/data/test_gen_surf_poscar.py
• ruff format --check dpgen/data/surf.py tests/data/test_gen_surf_poscar.py

This replaces #1931 solely to use the requested njzjz-bot submitter account. The head commit is unchanged.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[coderabbitai]

Warning

Review limit reached

Next included review available in 9 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c21c476-b121-46a6-b38c-e0a1abd501d0

📥 Commits

Reviewing files that changed from the base of the PR and between d5ce577 and 5f92f5e.

📒 Files selected for processing (2)

• dpgen/data/surf.py
• tests/data/test_gen_surf_poscar.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[njzjz-bot]

Independent review C

I found no blocking correctness, regression, security, or API issue in this change. CI/check evidence was considered alongside the full patch and relevant surrounding implementation. A formal APPROVE state cannot be submitted because the active njzjz-bot account is the PR author; GitHub self-review rules permit only a COMMENT review here.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent review B

No blocking findings. I reviewed the full diff, relevant surrounding behavior, tests, and current check status. GitHub does not permit njzjz-bot to APPROVE or REQUEST_CHANGES on its own pull request, so this review is recorded as COMMENT only.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent review A

No blocking findings after reviewing the full diff, relevant surrounding implementation/tests, and the current check rollup. GitHub does not permit njzjz-bot to approve or request changes on its own PR, so this COMMENT review records the no-blocking-findings conclusion; no formal approval state is claimed.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh