fix: preserve LAMMPS configuration indices - #384
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 104 104
Lines 6110 6111 +1
=======================================
+ Hits 5159 5160 +1
Misses 951 951 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Copy task-group configuration and only supply an empty conf_idx default when the caller omitted the field. Closes deepmodeling#358 Coding-Agent: Codex Codex-Version: codex-cli 0.149.1 Model: gpt-5.6-sol Reasoning-Effort: xhigh
4cf94ce to
83808a2
Compare
Retracted. This review was produced without running the mandated /code-review fan-out (the loop skill's section 2); the substitute process used instead has since been shown to miss findings and, in one case, to state a verified-sounding falsehood. Re-reviewing properly.
Summary
conf_idxvalueTests
PYTHONPATH=tests python -m unittest -v tests.exploration.test_make_task_group_from_config.TestMakeLmpTaskGroupFromConfig.test_npt_preserves_explicit_conf_idx tests.exploration.test_make_task_group_from_config.TestMakeLmpTaskGroupFromConfig.test_nptruff format --check dpgen2/exploration/task/make_task_group_from_config.py tests/exploration/test_make_task_group_from_config.pyisort --check-only dpgen2/exploration/task/make_task_group_from_config.py tests/exploration/test_make_task_group_from_config.pygit diff --checkCloses #358
Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh