Skip to content

Support list-valued Einstein spring constants - #157

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:develfrom
njzjz-bot:codex/issue-130-einstein-spring-list
Open

Support list-valued Einstein spring constants#157
njzjz-bot wants to merge 1 commit into
deepmodeling:develfrom
njzjz-bot:codex/issue-130-einstein-spring-list

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary:

  • accept per-type spring constants directly in einstein.free_energy
  • retain scalar spring scaling by atomic mass
  • add a Vega reference regression test

Tests:

  • PYTHONPATH=.. python -m unittest test_einstein.TestEinstein.test_vega_accepts_per_type_spring_constants -v
  • python -m ruff check --select I,F --ignore F841 dpti/einstein.py tests/test_einstein.py

Fixes #130

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Initialize per-type spring constants from a list when one is provided, while retaining scalar mass scaling. Add a regression test using the Vega reference job.

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 49 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01ecaffd-a3d2-4fe4-8ddc-f0423d1f4b2c

📥 Commits

Reviewing files that changed from the base of the PR and between 78091bd and 2e8caee.

📒 Files selected for processing (2)
  • dpti/einstein.py
  • tests/test_einstein.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (78091bd) to head (2e8caee).

Files with missing lines Patch % Lines
dpti/einstein.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           devel    #157   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      25           
  Lines       6665    6666    +1     
=====================================
- Misses      6665    6666    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] list-valued spring_k crashes einstein.free_energy

1 participant