Skip to content

Fix Einstein CLI JSON input handling - #158

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:develfrom
njzjz-bot:codex/issue-131-einstein-cli-input
Open

Fix Einstein CLI JSON input handling#158
njzjz-bot wants to merge 1 commit into
deepmodeling:develfrom
njzjz-bot:codex/issue-131-einstein-cli-input

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary:

  • let einstein.free_energy accept either a job directory or a JSON input path
  • pass the standalone CLI argument through as a path instead of a loaded dictionary
  • preserve relative configuration resolution and add regression coverage

Tests:

  • PYTHONPATH=.. python -m unittest test_einstein.TestEinstein.test_vega test_einstein.TestEinstein.test_vega_json_input_path -v
  • python -m ruff check --select I,F --ignore F841 dpti/einstein.py tests/test_einstein.py

Fixes #131

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Allow free_energy to load either a job directory or a JSON input path and pass the CLI argument through unchanged. Preserve relative configuration resolution and add regression coverage.

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 48 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 59f2bd95-b788-430f-a8e2-1371d385d458

📥 Commits

Reviewing files that changed from the base of the PR and between 78091bd and 3424846.

📒 Files selected for processing (2)
  • dpti/einstein.py
  • tests/test_einstein.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (78091bd) to head (3424846).

Files with missing lines Patch % Lines
dpti/einstein.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           devel    #158   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      25           
  Lines       6665    6667    +2     
=====================================
- Misses      6665    6667    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] einstein CLI passes the wrong type to free_energy

1 participant