Skip to content

Fix ZeRO-3 Muon all-gather for mixed parameter shapes - #8628

Open
jinyouzhi wants to merge 5 commits into
deepspeedai:masterfrom
jinyouzhi:fix_gloo_muon
Open

jinyouzhi wants to merge 5 commits into
deepspeedai:masterfrom
jinyouzhi:fix_gloo_muon

Conversation

@jinyouzhi

Copy link
Copy Markdown
Contributor

Follow up #8381
Fix 3 FAILED unit/v1/ops/muon/test_per_head_muon_accelerator.py in https://github.com/deepspeedai/DeepSpeed/actions/runs/35675316100/job/106580600974?pr=8381
@delock

Signed-off-by: Jin, Youzhi <youzhi.jin@intel.com>

@alanhuangyoo alanhuangyoo left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! I think this needs a rebase on #8600, the grads come from group_items there now since param.grad isn't the full grad at step time.

Btw NCCL seems fine with uneven all_gather, which is probably why only the gloo job failed.

@jinyouzhi

Copy link
Copy Markdown
Contributor Author

Thanks for picking this up! I think this needs a rebase on #8600, the grads come from group_items there now since param.grad isn't the full grad at step time.

Btw NCCL seems fine with uneven all_gather, which is probably why only the gloo job failed.

Thank you for remind! Yes, the ut only failed in Gloo, NCCL better compatible on this case.

jinyouzhi and others added 4 commits September 23, 2026 07:11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Jin, Youzhi <youzhi.jin@intel.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@alanhuangyoo alanhuangyoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the rebased version looks good to me. The ZeRO-3 Muon tests pass on 2×H20, and ZeRO-3 still matches ZeRO-0 bit for bit with mixed shapes.

@jinyouzhi

Copy link
Copy Markdown
Contributor Author

Thanks! @alanhuangyoo
@delock PTAL

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants