Use launcher world size before distributed init - #8685
Open
rohan-patnaik wants to merge 1 commit into
Open
rohan-patnaik wants to merge 1 commit into
rohan-patnaik wants to merge 1 commit into
Conversation
Signed-off-by: Rohan Patnaik <rohan-patnaik@users.noreply.github.com>
rohan-patnaik
requested review from
loadams,
tjruwase and
tohtana
as code owners
September 27, 2026 15:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6501.
When configuration is constructed before distributed initialization, use the launcher-provided
RANKandWORLD_SIZEinstead of assuming a single process. Preserve the single-process defaults and sequence-parallel world-size adjustment.Verification:
WORLD_SIZE=2repro: fails onmaster, passes after the changeCUDA_HOME