Skip to content

[refactor] acq Stream: remove unused attributes - #3546

Open
pieleric wants to merge 1 commit into
delmic:masterfrom
pieleric:refactor-acq-stream-remove-unused-attributes
Open

[refactor] acq Stream: remove unused attributes#3546
pieleric wants to merge 1 commit into
delmic:masterfrom
pieleric:refactor-acq-stream-remove-unused-attributes

Conversation

@pieleric

Copy link
Copy Markdown
Member

Moved a long time ago to RGBProjection

Moved a long time ago to RGBProjection
Copilot AI lite review requested due to automatic review settings August 11, 2026 06:45
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1872b8e1-5e5d-442c-9950-bc41b78c0957

📥 Commits

Reviewing files that changed from the base of the PR and between 7999c52 and cd0f0a3.

📒 Files selected for processing (1)
  • src/odemis/acq/stream/_base.py
💤 Files with no reviewable changes (1)
  • src/odemis/acq/stream/_base.py

📝 Walkthrough

Walkthrough

The Stream constructor no longer initializes the _projectedTilesCache and _rawTilesCache instance dictionaries.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the refactor and removal of unused attributes from the acquisition Stream.
Description check ✅ Passed The description explains that the functionality moved to RGBProjection, which relates directly to the removed Stream attributes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy tile-cache attributes from the base acquisition Stream implementation, aligning cache ownership with the projection layer (as indicated by the PR description that this was moved to RGBProjection/projection code long ago).

Changes:

  • Removed initialization of _projectedTilesCache and _rawTilesCache from Stream.__init__ in _base.py.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pieleric
pieleric requested a review from ilyushkin August 11, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants