Wire the window's AT-SPI Window role + Label property#3
Open
heath-toby wants to merge 1 commit into
Open
Conversation
Layer-shell windows on Wayland don't always get the default Window role and title-derived accessible name that xdg-shell toplevels do, so Orca's "present title bar" command (KP_Slash) reports "Could not find current location" when the popup is focused — even though `set_title` was called. Explicitly set `AccessibleRole::Window` and push the title into `AccessibleProperty::Label` so the name lands in the AT-SPI tree regardless of how the surface was mapped. This is the same direct-write pattern already used for the module items and menu buttons. Side benefit: my own sound-theme add-on listens for the focused window's title and was firing a "new window" sound on every keystroke because the title query came back empty. Surfacing the real title fixes that too. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer-shell windows on Wayland don't always get the default Window role and title-derived accessible name that xdg-shell toplevels do, so Orca's present title bar command (KP_Slash) reports "Could not find current location" when the popup is focused — even though
set_titlewas called.Explicitly set
AccessibleRole::Windowand push the title intoAccessibleProperty::Labelso the name lands in the AT-SPI tree regardless of how the surface was mapped. This is the same direct-write pattern already used for the module items and menu buttons inmodule_item.rs/menu_popover.rs.Test plan
🤖 Generated with Claude Code