fix: reset context metadata when loading a new context#329
Draft
plisker wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reset
PlayerState.ContextMetadatawhen loading a new context inloadContext, instead of merging the new context's metadata into the map left over from the previous one.Why
When switching from one context to another (e.g. starting an album while a different album is playing), every field of the new context —
SessionId,ContextUri,ContextUrl,Restrictions, tracks — is replaced, butContextMetadatawas only merged. Keys the previous context set that the new one omits therefore survived. Most visibly,context_descriptionlingered, so Spotify's queue kept showing "Next from: <previous album>" while the correct track played.The transfer path in
daemon/player.goalready resets the map before copying; this bringsloadContextin line. The same-URIupdate_contextpath still merges, which is correct there.Test plan
go build -v -o /dev/null ./cmd/daemongofmt -l .cleanCloses #330