fix(user): rate limit internal reauthentication attempts - #36
Open
devinhadley wants to merge 2 commits into
Open
fix(user): rate limit internal reauthentication attempts#36devinhadley wants to merge 2 commits into
devinhadley wants to merge 2 commits into
Conversation
Password change and email reset requests re-verify the caller's current password but never rate limited or recorded those attempts, letting a hijacked session brute-force the account password. Add a shared reauthentication auth_action, enforce the same failed-attempt limit login uses, and route both flows through one verifyReauthentication helper so switching endpoints can't widen the guessing budget. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VSYkKjv6rTX4ys77muo5jQ
…hash Both call sites already had the User in scope; deriving email and password hash inside the helper drops two redundant parameters. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VSYkKjv6rTX4ys77muo5jQ
devinhadley
force-pushed
the
33-user-from-request
branch
from
August 31, 2026 01:20
15e6dfe to
be45505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Password change and email reset requests re-verify the caller's current password but never rate limited or recorded those attempts, letting a hijacked session brute-force the account password. Add a shared reauthentication auth_action, enforce the same failed-attempt limit login uses, and route both flows through one verifyReauthentication helper so switching endpoints can't widen the guessing budget.
Claude-Session: https://claude.ai/code/session_01VSYkKjv6rTX4ys77muo5jQ