Fix for #1568 when RaiseAsync with a void Delegate returns null results in System.NullReferenceException

[Keugon]

Hi this is my best guess on improving information on issue when try to use the RaiseAsync() with a void Delegate with a more informativ Exception.

this is my first ever pullrequest and iam pretty sure i done many mistakes
#1568

Help Wanted here

[CLAassistant]

All committers have signed the CLA.

[Keugon]

is there more that i need to do so this can be considered?

[kzu]

void-returning async methods are a huge red flag in .NET. They lead to unobserved exceptions that can tear down a process. not sure we want to encourage that sort of design... 🤔

[kzu]

I'll still merge it because it's not introducing a breaking change from something that previously worked (nobody would set up this previously), so it's new behavior. Although there is a slight chance that someone was relying on the previous (unrelated) exception to catch this scenario (think: a pseudo-verification by side-effect), that would have been quite unlikely, I'd say.

[Keugon]

@kzu do i need to do anything here, iam still not very familiar with github and opensource repos, i just work with a local gitlab on company repos.

If i need to take action here please tell me

[kzu]

@copilot rebase on main and fix conflicts

[kzu]

@copilot resolve the merge conflicts in this pull request

[kzu]

@copilot resolve the merge conflicts in this pull request

[kzu]

@Keugon seems like copilot doesn't know how to resolve a conflict. if you still care about this getting merged, plz rebase on top of main and force-push to your fork branch so this PR updates and can be merged cleanly. Thanks

[Keugon]

@Keugon seems like copilot doesn't know how to resolve a conflict. if you still care about this getting merged, plz rebase on top of main and force-push to your fork branch so this PR updates and can be merged cleanly. Thanks

Will do that on monday!

[Keugon]

i rebased the fix but have issues on 2 tests
Can_raise_parameterized_async_event_using_RaiseAsync
Can_raise_async_event_using_RaiseAsync
as they are void but archive to not result in return null in internal static object? RaiseEvent(Mock mock, LambdaExpression expression, Stack<MethodExpectation> parts, object?[] arguments)

i need some help here to either adjust my raised exception on all void delegates or its fine to remove those tests as i cant decide if those are still valid scenarios? @kzu

[kzu]

deleting tests that ensure existing behavior remains valid is rarely a good idea :)

I'd put a good AI to spend high-reasoning tokens to figure it out if possible.