#1651: updated doc after generating new access token#2077
Conversation
Coverage Report for CI Build 28786648204Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.004%) to 71.792%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
maybeec
left a comment
There was a problem hiding this comment.
Thanks for refreshing the token and updating the guide — the clarifications (devonfw as resource owner, adding Metadata to the required permissions, dropping the obsolete AccessToken4 step) are all improvements. 👍
One rendering issue on the changed lines: image::../images/AccessToken3.png[...] (L30) directly follows the numbered step on L29 without a + list continuation. In AsciiDoc a block image placed immediately after a list item (no +) detaches from the list and terminates it, so the following steps (Click on Generate token, On the confirmation page ...) restart their numbering. The other images in this file are all attached with a leading + — the inline suggestion adds the missing one.
|
Good job updating the token documentation and the screenshots. I reviewed the changes and agree with the already mentioned AsciiDoc list continuation issue for |
Co-authored-by: Malte Brunnlieb <maybeec@users.noreply.github.com>
|
Retest: Documentation updated and all looking good. |
This PR updates the documentation for updating the access token
Implemented changes:
ACTION_PUSH_TOKENTesting instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal