Skip to content

#1651: updated doc after generating new access token#2077

Merged
hohwille merged 4 commits into
devonfw:mainfrom
hohwille:feature/1651-update-access-token-doc
Jul 6, 2026
Merged

#1651: updated doc after generating new access token#2077
hohwille merged 4 commits into
devonfw:mainfrom
hohwille:feature/1651-update-access-token-doc

Conversation

@hohwille

@hohwille hohwille commented Jun 26, 2026

Copy link
Copy Markdown
Member

This PR updates the documentation for updating the access token

Implemented changes:

  • Generated new access token and updated to our ACTION_PUSH_TOKEN
  • Took screenshots during the process
  • Updated the screenshots and documentation accordingly.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. There is nothing that can be tested explicitly.
  2. Review the documentation changes and view the new result on GitHub (in Browser)
  3. Observe our GitHub action workflows that all is still working (and when we merge PR #1651: push and commit status.json files to ide-urls-status after running the URL update worklfow #2003)

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jun 26, 2026
@hohwille hohwille added documentation Improvements or additions to documentation enhancement New feature or request SCM software-configuration-management (github actions, internal processes, git or github utilization) workflow GitHub actions (CI,CD,update urls/CVEs) labels Jun 26, 2026
@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board Jun 26, 2026
@hohwille hohwille added this to the release:2026.07.001 milestone Jun 26, 2026
@hohwille hohwille added the internal Nothing to be added to CHANGELOG, only internal story label Jun 26, 2026
@hohwille hohwille self-assigned this Jun 26, 2026
@coveralls

coveralls commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28786648204

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.004%) to 71.792%

Details

  • Coverage increased (+0.004%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16316
Covered Lines: 12208
Line Coverage: 74.82%
Relevant Branches: 7316
Covered Branches: 4758
Branch Coverage: 65.04%
Branches in Coverage %: Yes
Coverage Strength: 3.17 hits per line

💛 - Coveralls

@maybeec maybeec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refreshing the token and updating the guide — the clarifications (devonfw as resource owner, adding Metadata to the required permissions, dropping the obsolete AccessToken4 step) are all improvements. 👍

One rendering issue on the changed lines: image::../images/AccessToken3.png[...] (L30) directly follows the numbered step on L29 without a + list continuation. In AsciiDoc a block image placed immediately after a list item (no +) detaches from the list and terminates it, so the following steps (Click on Generate token, On the confirmation page ...) restart their numbering. The other images in this file are all attached with a leading + — the inline suggestion adds the missing one.

Comment thread documentation/contributing/update-access-token.adoc
@Caylipp

Caylipp commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Good job updating the token documentation and the screenshots.

I reviewed the changes and agree with the already mentioned AsciiDoc list continuation issue for AccessToken3.png. Apart from that, the documentation update looks good to me.

hohwille and others added 2 commits July 6, 2026 12:58
Co-authored-by: Malte Brunnlieb <maybeec@users.noreply.github.com>
@hohwille hohwille merged commit 37706b5 into devonfw:main Jul 6, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Team Review to ✅ Done in IDEasy board Jul 6, 2026
@hohwille

hohwille commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Retest: Documentation updated and all looking good.

@hohwille hohwille added the QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. SCM software-configuration-management (github actions, internal processes, git or github utilization) workflow GitHub actions (CI,CD,update urls/CVEs)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants