#2056 Replaced progress bar with progress information for plugin installation#2105
Open
oanding-blrng wants to merge 12 commits into
Open
Conversation
* Removed custom implementation of installPlugins() with progressbar in Vscode.java * Modified name of stop with progress marker "(n/m)" in installPlugins() in PluginBasedCommandlet.java.
…tive plugins and also use the total amount of active plugins instead of all.
oanding-blrng
added
enhancement
Collaborator
Coverage Report for CI Build 28850652896Coverage decreased (-0.03%) to 72.04%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions24 previously-covered lines in 6 files lost coverage.
Coverage Stats
💛 - Coveralls |
…ng progress marker.
…-progress-bar-for-vscode-plugins # Conflicts: # CHANGELOG.adoc
Contributor
|
Good Job on the Implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2056
Implemented changes:
(N/M)) in default implementation for installing plugins in PluginBasedCommandlet (progress marker should be visible also for installing plugins in other plugin based IDEs, if plugins are setup in settingsTesting instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
ide uninstall vscodeto force installationvscodeorinstall vscodeas the program argumentRetesting after Merge
ide uninstall vscodeto force installationide vscodeoride install vscodeChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal