#2102 set ideRoot during msi installation correctly#2149
Draft
quando632 wants to merge 9 commits into
Draft
Conversation
Collaborator
Coverage Report for CI Build 29099695688Coverage increased (+0.06%) to 72.287%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions183 previously-covered lines in 4 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2102
Implemented changes:
AbstractIdeContext:ideRootis no longerfinal; addedsetIdeRoot(Path)so the context canreflect the derived install target.
IdeContext: addedsetIdeRoot(Path)to the interface.IdeasyCommandlet.installIdeasy(...): after deriving the target viadetermineIdeRoot(cwd), itnow calls
context.setIdeRoot(...), keeping the whole install run consistent.AbstractIdeTestContext: removed the now-redundantideRoot/ideRootSetfields andgetIdeRoot/setIdeRootoverrides — the test context inherits the production setter, aligningtest and production behaviour.
IdeasyCommandletTest#testInstallIdeasyUpdatesIdeRoot(windows/mac/linux) that failswithout the fix and passes with it.
Verified the invariants called out in the issue are unaffected: the
isIdeRootRequiredgate inapplyAndRun, and the temp-download-path creation guarded byideRoot != nullin the constructor.Testing instructions
cli/, runmvn -Dtest=IdeasyCommandletTest test— all cases pass, includingthe new
testInstallIdeasyUpdatesIdeRoot. (Reverting thecontext.setIdeRoot(...)line makes the3 new cases fail, confirming the test reproduces the bug.)
IDE_ROOTis not set): run the IDEasy MSIinstaller, then open the install log at
IDE_ROOT\_ide\tmp\ideasy\ideasy\install.log. Confirm theWindows Terminal Git Bash configuration succeeds and there is no
Failed to configure Git Bash in Windows Terminal: nullmessage.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)internal