chore: track subnet query message response size in metrics#9875
Merged
chore: track subnet query message response size in metrics#9875
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Prometheus histogram to track the response payload size (bytes) of subnet query message executions, to support monitoring/alerting on query response growth.
Changes:
- Add a new
execution_subnet_query_message_response_byteshistogram (labeled bymethod_name). - Update
QueryHandlerMetrics::observe_subnet_query_messageto acceptResult<WasmResult, UserError>and record reply-size samples for successful replies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alin-at-dfinity
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tracks subnet query message response size in metrics. The motivation for this change is ability to monitor response sizes of the
list_canistersquery endpoint added by this PR.For consistency, the label
ErrorCode::CanisterRejectedMessageis introduced for the caseOk(WasmResult::Reject(_)).