feat(governance): expose get_maturity_modulation query endpoint#9879
Draft
jasonz-dfinity wants to merge 2 commits intojason/NNS1-4319-compute-maturity-modulationfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes the Mission 70 “maturity modulation” value through the Governance canister’s public Candid interface so external tools/dashboards can query it.
Changes:
- Added
MaturityModulation,GetMaturityModulationRequest, andGetMaturityModulationResponsetoic-nns-governance-api. - Added
Governance::get_maturity_modulation()and a corresponding#[query] get_maturity_modulationcanister endpoint. - Updated
governance.didand added the required pb→api conversion forMaturityModulation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rs/nns/governance/src/pb/conversions/mod.rs | Adds pb→api From conversion for MaturityModulation. |
| rs/nns/governance/src/governance.rs | Adds a getter that exposes maturity modulation from heap state via API response type. |
| rs/nns/governance/canister/governance.did | Declares new request/response + MaturityModulation types and adds the new service method. |
| rs/nns/governance/canister/canister.rs | Implements the new public query endpoint that returns the modulation value. |
| rs/nns/governance/api/src/types.rs | Introduces new public API types for the query endpoint and payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
40e573b to
ebb47a9
Compare
0724790 to
9a31ba9
Compare
ebb47a9 to
83dc934
Compare
9a31ba9 to
a7108f0
Compare
ee64f46 to
5ff783e
Compare
5ff783e to
c1a9ced
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #9847 computes maturity modulation locally but does not expose it via the canister API.
This adds a query endpoint so that external tools and dashboards can read the current
maturity modulation value, as defined by Mission 70.
https://dfinity.atlassian.net/browse/NNS1-4319
What
PR Chain