Conversation
…30s stream disconnect
🦋 Changeset detectedLatest commit: 07d2130 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Live WebRTC streams terminate after ~30 seconds with Ring closing the session:
reason: { code: 6, text: 'Timeout waiting for ping' }(oranswered_timeout).Root Cause
While
WebrtcConnectionperiodically transmitspingrequests to the Ring RMS server, the server also sends{"method":"ping"}keepalives to the client.In
handleMessage(), incoming serverpingmessages are not recognized, falling through the switch statement tologError('UNKNOWN MESSAGE')without dispatching an acknowledgement. When Ring's media gateway does not receive apongreply within its timeout window, it terminates the stream.Solution
PingMessageinterface and included it inIncomingMessage.case 'ping':inhandleMessage()to immediately acknowledge withthis.sendSessionMessage('pong').