Skip to content

CMPSC 302: Code Review #3

Description

@Jake-College

Which design principles does the reviewee's site implement effectively?

  • Aligment
  • Balance
  • Symmetry
  • Visual Hierarchy
  • Negative Space
  • Color
  • Type

Examples of areas where the site designer uses design principles.

Design Principles

Use markdown heading 5 and 6 to describe how the designer used each principle checked above.

Alignment
Site is aligned well with no overlap or conflicts, and alignment is consistent within elements.
Symmetry
Site is intentionally asymmetrical and poses no issues with symmetry.
Hierarchy
Site has proper hierarchy and uses one singular large header with correctly-trickling-down sizes.
Negative Space
Site uses negative space to separate elements well.
Color
Site is not overly flashy or presenting any issues with readability.
Type
Type is readable and functions well.

Which design principles should the designer revisit?

  • Aligment
  • Balance
  • Symmetry
  • Visual Hierarchy
  • Negative Space
  • Color
  • Type

Examples of areas where the site designer should revise their use of a pirnciple

Design Principles

Use markdown heading 5 and 6 to describe how the designer used each principle checked above.

Balance
Site feels lopsided with the lower section protruding from the left

This site has at least one page which is reviewable and publically availble at the reviewee's *.github.io URL.

Yes

Reviewee's site implements at least 3 Astro components.

Yes

Reviewee's site effectively implements a BaseLayout (or other similar construct) for controlling site-wide layout.

Yes

Site being reviewed implements styles in the public/style/style.css file.

Yes

The sites's BaseLayout contains a <!DOCTYPE> tag

Yes

The site's BaseLayout uses the root element tag and specifies en as the page's language.

Yes

The sites's BaseLayout uses the root element tag and specifies en as the page's language.

Yes

Throughout all files, the site uses semantic elements where appropriate, only using div elements where semantic elements don't exist.

Yes

Examples of improper use of non-semantic elements.

  <!-- Use code blocks to include examples -->

Does the markup of the site use any single ID more than once?

No

Which IDs are used more than once?

No response

Does the markup contain superfluous, un-necessary
elements?

No

Examples of superfluous
tags.

  <!-- Use code blocks to include examples -->

If needing ARIA attributes, does the site use them in the correct places?

Does not apply

Examples of elements requiring ARIA attributes.

  <!-- Use code blocks to include examples -->

The names of the various CSS rules implemented make sense in the context of their use.

Yes

Which rules use confusing, non-descriptive, or ambiguous names?

No response

Where possible, the designer uses CSS variables to unify colors, types, or other CSS properties.

Yes

Are padding, margin, and border used correctly?

Yes

Examples of elements misusing the above properties.

  /* Use code blocks to include examples */

Does the designer use absolute units (i.e., pixels) instead of relative units?

Yes

Do any CSS rules appear repetitive or redundant? Could some be conslidated into one rule with mulitple uses?

No

Examples of repetitive or redundant rules.

  /* Use code blocks to include examples */

Provide areas where the designer's work demonstrates a grasp of course principles.

  1. General design - the site clearly follows with lessons on how to make the site look appealing to the general public.
  2. Accessibility - the site follows lessons on how to be accessible for people who may be sensitive to various problems.
  3. Code standards - the site follows with coding standards lessons with functionality, minimization of errors in code, and accuracy and correct use of terms.

Provide areas where the designer's work could use revision.

  1. Balance (as stated above)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions