feat: [DHIS2-21266] Integrate react Markdown lib#4595
Open
fernandogmz wants to merge 6 commits into
Open
Conversation
fernandogmz
commented
Jun 1, 2026
fernandogmz
commented
- Integrate react markdown library to support standard md elements
- Apply corresponding legend sets for rule actions where apply
- Create Markdown e2e testing for markdown integration
- Integrate react markdown library to support standard md elements - Apply corresponding legend sets for rule actions where apply - Create Markdown e2e testing for markdown integration
simonadomnisoru
changed the title
simonadomnisoru
left a comment
simonadomnisoru
left a comment
Contributor
There was a problem hiding this comment.
Hi @fernandogmz,
Great work on this ticket! I've left a few suggestions below:
- Folder & File Structure: I left a few comments on how to reorganize the structure a bit.
- Cypress Tests: Please update the
eventIdin the Cypress tests as explained in the detailed comment. - CI Run: The CI isn't running on this PR because we don't currently have it set up to run on PR comming from external forks. We are thinking about the best approach to handle this. For now, let’s focus on the first two points, and we can deal with the CI afterward.
Please let me know if any of the comments are unclear or if you need more input from me. Thank you!
* Folder structure * Update cypress tests
simonadomnisoru
left a comment
simonadomnisoru
left a comment
Contributor
There was a problem hiding this comment.
Hi @fernandogmz,
Due to current security limitations where CI checks do not run on external forks, I have cherry-picked your commits into a separate PR (#4621) as a workaround to get your work merged.
The only remaining point to decide is whether we should store legendSets in IndexedDB alongside other metadata. I have brought this up to the Tech Lead, and we should have a decision on this soon.
Thank you!
- Wrap MarkdownWrapper component with React.memo - Remove unused priority parameters at rulesEffectsProcessor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.