Skip to content

chore: use last year's periods#3321

Draft
edoardo wants to merge 4 commits into
masterfrom
chore/adjust-tests-using-last-year
Draft

chore: use last year's periods#3321
edoardo wants to merge 4 commits into
masterfrom
chore/adjust-tests-using-last-year

Conversation

@edoardo

@edoardo edoardo commented Jan 2, 2025

Copy link
Copy Markdown
Member

Key features

  1. use last year's period wherever possible

Description

This is to avoid failing tests in the beginning of a new year when the new data is not added to the test DB yet.

This is to avoid failing tests in the beginning of a new year when the
new data is not added to the test DB yet.
@dhis2-bot

dhis2-bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://pr-3321.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify January 2, 2025 14:34 Inactive
This is to avoid failing tests in the beginning of a new year when the
new data is not added to the test DB yet.
@dhis2-bot dhis2-bot temporarily deployed to netlify January 3, 2025 15:12 Inactive
Comment thread cypress/integration/options/totals.cy.js Outdated
@dhis2-bot dhis2-bot temporarily deployed to netlify January 8, 2025 09:55 Inactive
@edoardo edoardo marked this pull request as draft January 8, 2025 14:55
@edoardo

edoardo commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

I converted to Draft since I realised the data is not the same for all the years, so some tests now fail because they expect a different value.
It's easy to fix the tests where there is actual data for both the current and the last year, but in some cases there is only data for the current year, so for those we would have to add the data to the DB dump.

@dhis2-bot dhis2-bot temporarily deployed to netlify January 9, 2025 10:03 Inactive
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants