Let the theme's assets back through the exclusion - #30
Merged
Merged
Conversation
Excluding every directory under docs/ also swept away the stylesheets the theme serves through the same filter, and a strict build says nothing when that happens — the site deployed as bare HTML. The assets come back through by name, and the workflow now refuses to ship a build without them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wholesale directory exclusion under docs/ also filtered the theme's own stylesheets and scripts, and a strict build stays green when that happens, so the site deployed as bare HTML. The assets are re-included by name, and the build job now checks the stylesheet actually made it into the site before anything ships.