Skip to content

Commit 421a8c4

Browse files
committed
fix: use variable assignment instead of heredoc for YAML compatibility
- Replace heredoc with shell variable assignment for release notes - Avoid YAML parsing issues with complex syntax - Properly escape backticks for markdown code blocks
1 parent 8e07da1 commit 421a8c4

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

.github/workflows/publish-to-releases.yml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,8 @@ jobs:
134134
135135
echo "Creating release: $RELEASE_TAG"
136136
137-
# Create release notes file
138-
cat > /tmp/release_notes.txt << 'NOTES'
139-
Pre-compiled gRPC extension for PHP ${PHP_VERSION}
137+
# Create release dengan artifacts
138+
NOTES="Pre-compiled gRPC extension for PHP ${PHP_VERSION}
140139
141140
gRPC Version: ${GRPC_VERSION}
142141
PHP Version: ${PHP_VERSION}
@@ -145,24 +144,24 @@ Architectures: AMD64, ARM64
145144

146145
## Usage in Dockerfile:
147146

147+
\`\`\`dockerfile
148148
FROM php:${PHP_VERSION}-fpm
149149

150-
RUN curl -L -o /tmp/grpc.so \
151-
https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-amd64.so && \
152-
mv /tmp/grpc.so /usr/local/lib/php/extensions/no-debug-non-zts-20220829/grpc.so && \
153-
docker-php-ext-enable grpc && \
150+
RUN curl -L -o /tmp/grpc.so \\
151+
https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-amd64.so && \\
152+
mv /tmp/grpc.so /usr/local/lib/php/extensions/no-debug-non-zts-20220829/grpc.so && \\
153+
docker-php-ext-enable grpc && \\
154154
rm -rf /tmp/*
155+
\`\`\`
155156

156157
## Available Downloads:
157158

158159
- grpc-amd64.so: https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-amd64.so
159-
- grpc-arm64.so: https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-arm64.so
160-
NOTES
160+
- grpc-arm64.so: https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-arm64.so"
161161

162-
# Create release dengan artifacts
163162
gh release create "$RELEASE_TAG" \
164163
--title "$RELEASE_NAME" \
165-
--notes-file /tmp/release_notes.txt \
164+
--notes "$NOTES" \
166165
artifacts/grpc-amd64.so \
167166
artifacts/grpc-arm64.so
168167

0 commit comments

Comments
 (0)