Show built-in extensions in marketplace#2008
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/src/react-app/domains/settings/settings-extension-controller.ts">
<violation number="1" location="apps/app/src/react-app/domains/settings/settings-extension-controller.ts:82">
P2: `useCallback` with `[input]` as dependency is effectively a no-op since `input` is a fresh object literal on every render. The memoization never caches. Either destructure the specific primitive/stable values from `input` into the dependency array, or accept that memoization isn't needed here and remove `useCallback` to avoid misleading readers.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| @@ -0,0 +1,107 @@ | |||
| /** @jsxImportSource react */ | |||
There was a problem hiding this comment.
P2: useCallback with [input] as dependency is effectively a no-op since input is a fresh object literal on every render. The memoization never caches. Either destructure the specific primitive/stable values from input into the dependency array, or accept that memoization isn't needed here and remove useCallback to avoid misleading readers.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/app/src/react-app/domains/settings/settings-extension-controller.ts, line 82:
<comment>`useCallback` with `[input]` as dependency is effectively a no-op since `input` is a fresh object literal on every render. The memoization never caches. Either destructure the specific primitive/stable values from `input` into the dependency array, or accept that memoization isn't needed here and remove `useCallback` to avoid misleading readers.</comment>
<file context>
@@ -0,0 +1,107 @@
+ envKeyDetected: hasOpenAiEnv(input),
+ },
+ localProvider: input.localProvider,
+ }), [input]);
+
+ const configSlotForEntry = useCallback(
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
E2E Evidence