1.10.3#298
Merged
Merged
Conversation
This was
linked to
issues
Jun 3, 2026
Closed
Closed
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR releases v1.10.3: bumps version/build metadata, refactors CLI and types output to return strings, pluralizes PokemonFlags, improves GitHub latest-release error handling, and adds deprecation warnings and docs updates. ChangesVersion 1.10.3 Release and Refactoring
Sequence DiagramsequenceDiagram
participant runCLI
participant currentVersion
participant latestReleaseFromURL
participant GitHub
runCLI->>currentVersion: request formatted version
currentVersion-->>runCLI: return "Version: …"
runCLI->>latestReleaseFromURL: request latest release (User-Agent set)
latestReleaseFromURL->>GitHub: GET /releases/latest (with headers)
GitHub-->>latestReleaseFromURL: 200 or rate-limit response (X-RateLimit-*)
latestReleaseFromURL-->>runCLI: release data or formatted rate-limit error
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)
99-99:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAlign CI Go version with
go.mod/Dockerfile (1.25.10)CI uses Go
1.25.9in.github/workflows/ci.yml, while the repo’s build config targets Go1.25.10(Dockerfilebase imagegolang:1.25.10-alpine3.23andgo.modusesgo 1.25.10). This toolchain mismatch can cause inconsistent build behavior.🔧 Proposed fix to align Go versions
- name: Set up Go uses: actions/setup-go@v6 with: - go-version: '1.25.9' + go-version: '1.25.10'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml at line 99, Update the CI workflow's Go toolchain version entry so it matches the repository's build config: change the go-version key value used in .github/workflows/ci.yml from "1.25.9" to "1.25.10" (the same version declared in go.mod and used by the Dockerfile base image). This ensures consistency across the "go-version" setting and the repository toolchain.
🧹 Nitpick comments (1)
cmd/tcg/tcg.go (1)
93-97: ⚡ Quick winAdd newline before deprecation warning for consistency.
The
naturescommand adds a newline before its deprecation warning (natures.go line 71), but this implementation writes the warning directly. While bubbletea programs should leave the terminal in a clean state, adding a newline improves consistency and defensive formatting.♻️ Suggested addition for consistency
} + output.WriteString("\n") deprecationWarning := styling.WarningBorder.Render( styling.WarningColor.Render("⚠ Warning!"),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/tcg/tcg.go` around lines 93 - 97, Prepend a newline before the deprecation warning so formatting matches other commands: when building or writing deprecationWarning (created via styling.WarningBorder.Render / styling.WarningColor.Render) ensure you prefix it with "\n" (or write a separate output.WriteString("\n") before output.WriteString(deprecationWarning)) so the terminal shows a blank line before the warning for consistency with the natures command.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli.go`:
- Line 56: Replace the two fmt.Sprintf usages that format the literal "Version:
%s" (and the similar second occurrence flagged by the linter) with simple string
concatenation (e.g., "Version: " + version) to satisfy the perfsprint lint rule;
update the expressions where the format strings "Version: %s" and the other
flagged format are used and keep the fmt import intact since it’s used elsewhere
(no other behavior changes required).
In `@README.md`:
- Line 245: Replace the misspelled word "consistancy" with "consistency" in the
README line describing the pokemon command (the line mentioning `pokemon <name>
--defense` being renamed to `--defenses`) so the sentence reads "...to keep
consistency with other flags in the `pokemon` command."
---
Outside diff comments:
In @.github/workflows/ci.yml:
- Line 99: Update the CI workflow's Go toolchain version entry so it matches the
repository's build config: change the go-version key value used in
.github/workflows/ci.yml from "1.25.9" to "1.25.10" (the same version declared
in go.mod and used by the Dockerfile base image). This ensures consistency
across the "go-version" setting and the repository toolchain.
---
Nitpick comments:
In `@cmd/tcg/tcg.go`:
- Around line 93-97: Prepend a newline before the deprecation warning so
formatting matches other commands: when building or writing deprecationWarning
(created via styling.WarningBorder.Render / styling.WarningColor.Render) ensure
you prefix it with "\n" (or write a separate output.WriteString("\n") before
output.WriteString(deprecationWarning)) so the terminal shows a blank line
before the warning for consistency with the natures command.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 56f7fecb-96a0-4360-9406-5fac31cd78bc
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (22)
.github/workflows/ci.yml.goreleaser.ymlDockerfileREADME.mdcard_data/pipelines/poke_cli_dbt/dbt_project.ymlcard_data/pyproject.tomlcli.gocli_test.gocmd/natures/natures.gocmd/pokemon/pokemon.gocmd/search/model_input.gocmd/tcg/tcg.gocmd/types/damage_table.gocmd/types/damage_table_test.gocmd/types/types.godocs/installation.mdflags/pokemonflagset.goflags/pokemonflagset_test.gogo.modnfpm.yamltestdata/natures.goldenweb/pyproject.toml
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes / Improvements
Documentation
Chores