perf: remove per-request async overhead in router dispatch - #354
Open
nigrosimone wants to merge 1 commit into
Open
perf: remove per-request async overhead in router dispatch#354nigrosimone wants to merge 1 commit into
nigrosimone wants to merge 1 commit into
Conversation
- start req.routeCount at 1 so the first route of a request takes the synchronous _preprocessRequest path: 0 % 300 === 0 forced an await on every single request, deferring the whole handler chain to a microtask - make next() a plain function instead of async, removing an unconsumed promise allocation on every middleware/handler step; the nested router branch now chains with .then() instead of await
nigrosimone
marked this pull request as ready for review
July 30, 2026 05:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
req.routeCountat 1 so the first route of a request takes the synchronous_preprocessRequest path: 0 % 300 === 0forced an await on every single request, deferring the whole handler chain to a microtasknext()a plain function instead ofasync, removing an unconsumed promise allocation on every middleware/handler step; the nested router branch now chains with.then()instead ofawaitmiddlewares-100 (+26%) e nested-routers (+21%)
MASTER (LATEST COMMIT)
PR