feat(geometry): add face_towards to 2D isometries#1605
Open
wilmerdooley wants to merge 1 commit into
Open
Conversation
Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
face_towardsconstructor for 2D isometries (Isometry2andIsometryMatrix2) that mirrors the existing 3D behavior. The new method builds an isometry from aneyepoint and atargetpoint, mapping the localxaxis to the view direction and the origin toeye, which is useful for orienting objects toward a target in 2D.A deprecated
new_observer_framealias is also provided on the 2D types for consistency with the 3D naming, and the rustdoc section inisometry.rsis updated to list the new constructor.Resolves #492
Changes
Isometry2::face_towardsandIsometryMatrix2::face_towardsinsrc/geometry/isometry_construction.rs, computing the rotation fromatan2(dy, dx)betweeneyeandtarget.new_observer_framealiases on both 2D isometry types, delegating toface_towards.Isometryrustdoc to mentionface_towards.tests/geometry/isometry.rscovering both 2D types, verifying that the origin maps toeyeand thexaxis maps to the normalized view direction.