refactor: Import structure nodes#2427
Merged
Merged
Conversation
… don't necessarily know how to convert to the element) and implement basic EPSR ato structure import.
trisyoungs
force-pushed
the
dissolve2/import-structure-nodes
branch
from
9647cb3 to
3fb5af1
Compare
Contributor
RobBuchananCompPhys
left a comment
RobBuchananCompPhys
left a comment
There was a problem hiding this comment.
Looks great 👍 ...it would be nice to see the new Node::message interface being used more widely (instead of Messenger::print - unless this is strictly necessary for some reason?)
Member
Author
Ah - absolutely! Missed those going through. |
Co-authored-by: RobBuchanan <106311829+RobBuchananCompPhys@users.noreply.github.com>
RobBuchananCompPhys
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR effectively moves all code from
CoordinateImportFileFormatinto individual nodes which output aStructureobject. All of the new unit tests are updated accordingly.The old
CoordinateImportFileFormatis not removed as it is still depended on byTrajectoryImportFileFormat(to be converted in a follow-up PR).