Replace XUnit tests with NUnit - #7502
Open
bdukes wants to merge 1 commit into
Open
Conversation
bdukes
force-pushed
the
xunit-to-nunit
branch
2 times, most recently
from
September 8, 2026 18:53
7109496 to
7b5ddfb
Compare
bdukes
force-pushed
the
xunit-to-nunit
branch
from
September 8, 2026 18:59
7b5ddfb to
58a7403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Bulk Install project was brought in using XUnit for testing, while the rest of the project uses NUnit. This means that the tests don't even get run/reported in CI. For the sake of consistency and reducing dependencies, I've migrated those tests to NUnit.
Those tests also use FakeItEasy (other DNN tests use Moq) and Shouldly (other DNN tests use NUnit's assertion library). Ideally we would also introduce some consistency there, but it's a more impactful change than I wanted to take right now.